Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting configuration files #2459

Merged
merged 25 commits into from
Mar 29, 2024
Merged

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Mar 22, 2024

Summary of the pull request

DevHome will now detect a configuration file in a repos .configuration folder. If one is found, the file name, along with the repo name, will be shown in the summary screen along with two options.

  1. View the file
  2. Run the file

Running the file opens up an admin CMD with "winget [filename]"

This PR includes the ability for other tasks to add their own custom next steps that will show in the summary screen.

References and relevant issues

This PR also moves LoadingMessageViewModel into the service collection.

Detailed description of the pull request / Additional comments

Validation steps performed

Manually ran the scenarios including making a devdrive and cloning.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Movies!

All repos downloaded have a config file + view file and run file
FilesEqualDownloads

Some config files found. One repo encountered an error
FilesWithCloningError

Pictures!
More repos cloned than config files found
FilesDoesNotEqualRepos

Loading screen errors and no config files found.
ErrorsWithNoFIles

Copy link
Member

@jsidewhite jsidewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dhoehna dhoehna merged commit caa1378 into main Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Second Pull request that needs another approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Home Feature Exploration: Detect a configuration file when cloning a repo
5 participants