-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hyper-V Extension] Add ability for the Hyper-V extension to create VMs from the VM gallery #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonaby
force-pushed
the
user/bbonaby/add-hyper-v-creation
branch
from
March 20, 2024 16:18
f1be31d
to
249da9d
Compare
bbonaby
requested review from
sshilov7,
huzaifa-d,
SohamDas2021,
jsidewhite and
dhoehna
March 20, 2024 17:11
sshilov7
reviewed
Mar 21, 2024
sshilov7
reviewed
Mar 21, 2024
sshilov7
reviewed
Mar 21, 2024
HyperVExtension/src/HyperVExtension/Models/VMGalleryJsonToClasses/VMGalleryImageList.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
Mar 21, 2024
HyperVExtension/src/HyperVExtension/Models/VirtualMachineCreation/DotNetZipArchiveProvider.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
Mar 21, 2024
HyperVExtension/src/HyperVExtension/Models/VirtualMachineCreation/ArchiveExtractionOperation.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
Mar 21, 2024
...VExtension/src/HyperVExtension/Models/VirtualMachineCreation/VMGalleryVMCreationOperation.cs
Show resolved
Hide resolved
sshilov7
reviewed
Mar 21, 2024
...VExtension/src/HyperVExtension/Models/VirtualMachineCreation/VMGalleryVMCreationOperation.cs
Show resolved
Hide resolved
sshilov7
reviewed
Mar 22, 2024
HyperVExtension/src/HyperVExtension/Providers/HyperVProvider.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
Mar 22, 2024
HyperVExtension/src/HyperVExtension/Services/IDownloaderService.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
Mar 22, 2024
...tension/test/HyperVExtension/HyperVExtensionTests/Services/HyperVExtensionIntegrationTest.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
Mar 22, 2024
...tension/test/HyperVExtension/HyperVExtensionTests/Services/HyperVExtensionIntegrationTest.cs
Show resolved
Hide resolved
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
HyperVExtension/src/HyperVExtension/Models/VirtualMachineCreation/DotNetZipArchiveProvider.cs
Show resolved
Hide resolved
dhoehna
reviewed
Mar 25, 2024
HyperVExtension/src/HyperVExtension/Models/VirtualMachineCreation/DotNetZipArchiveProvider.cs
Show resolved
Hide resolved
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
dhoehna
reviewed
Mar 25, 2024
sshilov7
approved these changes
Mar 25, 2024
kanismohammed
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR adds creation to the Hyper-V extension. For V1 we're utilizing the images within the Hyper-V VM gallery. These images are hosted by microsoft and can be located here: https://go.microsoft.com/fwlink/?linkid=851584. The following was added to the extension:
The flow is the following:
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Note When I add the UX code to Dev Home, I intend to update this so the User can cancel the operation.
I also noted that some of the unit tests are broken, but will fix in a subsequent PR.
I added new unit tests and an integration test to confirm this is all working as intended.
PR checklist