Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Extensions page to NavigationView footer #2431

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Move Extensions page to NavigationView footer #2431

merged 1 commit into from
Mar 20, 2024

Conversation

krschau
Copy link
Contributor

@krschau krschau commented Mar 19, 2024

Summary of the pull request

  • Remove ExtensionLibrary from NavConfig.json since it no longer should show up in the top
  • Add it to the footer in ShellPage
  • Since it no longer gets added to the page service automatically by being in NavConfig, add ExtensionLibraryViewModel to the page service with the other page in that project.

Validation steps performed

Locally validated.

PR checklist

@krschau krschau merged commit 39be39b into main Mar 20, 2024
4 checks passed
@krschau krschau deleted the user/krschau/move-extension-page branch March 20, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vineeththomasalex vineeththomasalex vineeththomasalex approved these changes

@AmelBawa-msft AmelBawa-msft AmelBawa-msft approved these changes

@guimafelipe guimafelipe Awaiting requested review from guimafelipe

@dkbennett dkbennett Awaiting requested review from dkbennett

@EricJohnson327 EricJohnson327 Awaiting requested review from EricJohnson327

@bbonaby bbonaby Awaiting requested review from bbonaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Extensions page down to the Footer
3 participants
@krschau @vineeththomasalex @AmelBawa-msft