Update widget positions on widget deletion #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (e.OldItems != null) | ||
| { | ||
| await _pinnedWidgetsLock.WaitAsync(); |
There was a problem hiding this comment.
Should this lock also be used in other methods where the shared resources are accessed (read/write)?
There was a problem hiding this comment.
We have a to-do in the code with a work item for doing better concurrency, #1215. TBH I'm tempted to do it separately.
EricJohnson327
approved these changes
Mar 11, 2024
guimafelipe
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
There is a bug where Dashboard can lose the order of widgets if some widgets are deleted (so the PinnedWidget count goes down, but the saved position index of the last widget stays the same) and then widgets are added (with a saved position index now less than or equal to the saved position index of the last widget(s). This change prevents this scenario by listening for when a widget is deleted, and then updating the saved position index of any subsequent widgets whose positions have now moved up in the list.
We stop listening to this event during drag and drop, since drop removes (and re-adds) a widget and takes care of re-numbering any affected widgets already.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Tested locally.
PR checklist