Fixing accessibility bug on Widget MenuFlyout item #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineeththomasalex
approved these changes
Mar 6, 2024
krschau
approved these changes
Mar 6, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
There is a bug when the narrator should be saying "Menu item, medium, selected" for the size items on the menu flyout for the widgets. The problem is that for the menu flyout, the itens doesn't expose the Selection Pattern for the automation clients. Using the
ItemStatusautomation property was not working as the narrator not uses that property in its narrations.To fix this, was created a new control class with a new automation peer, that implements the Selection Pattern and exposes it to the automation clients. This control is being used only by the items related to widget sizes.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/45055204
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist