-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Added Percentage memory in widget #2335
Conversation
@microsoft-github-policy-service agree |
Hi @Gobinath-B, thanks for working on this! I think you missed adding some files to this pull request, I only see the json template changes. I'm going to convert this to a draft PR, but please convert it back when the code is ready for review and we'll take a look! |
hai @krschau , when i started working on this the calculation code for memory percentage was already writed but it was never used in adaptive card .So i used that LoadContentData in adaptive card json.
this is the function already wrote in SystemMemoryWidget.cs |
@krschau hi did you check my last comment |
Hi @Gobinath-B, sorry for the delayed reply. I see what you mean that the code was always there, and you're exposing it. Nice catch! This week we're in stabilization mode to prepare for the 0.12 release, so we're only checking in a specific set of PRs right now. After this coming Tuesday, the main branch will open back up and we'll be ready to take this change. It would be great if you could update your fork to resolve the merge conflict that's showing, as well as removing the json file that got checked in. Thanks! |
@krschau Got it thanks for the reply |
hai @krschau is that the stabilization sprints are over? |
extensions/CoreWidgetProvider/Widgets/Templates/SystemMemoryTemplate.json
Outdated
Show resolved
Hide resolved
@krschau finished the requested changes |
extensions/CoreWidgetProvider/Widgets/Templates/SystemMemoryTemplate.json
Outdated
Show resolved
Hide resolved
@krschau I done the changes you mentioned above. ready to review |
I tested the widget and it never fills in a number for Utilization. I don't see anywhere in the code that a variable called Utilization is being set. You need to add a variable to memoryData with the Percentage data. |
Okay lemme check |
@krschau actually i go through the code and find out there is a variable for Percentage data named memUsage
So that i put that variable name ${memUsage} in SystemMemoryTemplate.json
Ready to review @krschau ,Have a good day. |
Thanks for your work. New feature is coming!!! |
@KurroLopez Thank you so much :) |
Summary of the pull request
This pull request adds a new feature to the memory widget, displaying the memory usage percentage. It includes changes to both the frontend (Adaptive Card template) and the backend (C# code) to incorporate this functionality.
References and relevant issues
#1986
Detailed description of the pull request / Additional comments
The changes in this pull request involve:
Additional comments or explanations, if any, can be provided here.
Validation steps performed
PR checklist