Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give accessible name to Manage Extension toggle, prevent clipping in Feedback when text is scaled #2292

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

EricJohnson327
Copy link
Contributor

@EricJohnson327 EricJohnson327 commented Feb 21, 2024

Summary of the pull request

  1. Removing the stackpanel allows for the Name field to be automatically populated. This also matches how we do toggle switches in settings cards other places.
  2. Switching from height to minheight to fix remove clipping when at 200+% zoom.

References and relevant issues

https://dev.azure.com/microsoft/OS/_workitems/edit/47259187/
https://dev.azure.com/microsoft/OS/_workitems/edit/48152830/

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@EricJohnson327 EricJohnson327 merged commit f15296e into main Feb 22, 2024
4 checks passed
@EricJohnson327 EricJohnson327 deleted the user/ejohn/accessibilityFixes branch February 22, 2024 19:52
@krschau krschau added this to the Dev Home v0.12 milestone Feb 22, 2024
@krschau krschau removed this from the Dev Home v0.12 milestone Mar 7, 2024
@krschau krschau changed the title Accessibility fixes Give accessible name to Manage Extension toggle, prevent clipping in Feedback when text is scaled Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility fixes for 0.12 milestone
3 participants