Show error if creating a widget fails #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
approved these changes
Feb 15, 2024
dhoehna
reviewed
Feb 15, 2024
| <value>Dev Home encountered an error. The widget could not be created.</value> | ||
| <comment>Error that pops up in a message dialog when the user tries to pin a widget but the widget could not be created.</comment> | ||
| </data> | ||
| <data name="CloseButtonText" xml:space="preserve"> |
There was a problem hiding this comment.
I thought the dialog would come with a close button and the button was set to the correct content?
There was a problem hiding this comment.
It's not automatic, the ShowErrorMessageDialogAsync() method requires ButtonText. BUT, the (now) three places in the code all use "Close". Sounds like the best thing to do would be to make the button text optional with a default of "Close".
There was a problem hiding this comment.
dhoehna
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
If the user tries to add a widget but creating the widget fails, show an error instead of failing silently.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist