Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Widget Pin flow to show preview images #2110

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Jan 8, 2024

Summary of the pull request

Change Dev Home's flow for pinning widgets to align with the Windows Widget Board. In the Add Widget dialog (aka widget picker), the user is shown widget preview images, and any configuration is done inline on the Dashboard.

References and relevant issues

Detailed description of the pull request / Additional comments

  • Instead of widget creation happening in the "Add Widget" dialog, we only create the widget after the widget has been pinned. This lets us simplify the Add Widget dialog, since we're only selecting a WidgetDefinition there. We no longer have to specially handle the popup or window closing, because there is no "partially created" widget to delete.
  • Since widget customization is done in-line, Dev Home as a widget host no longer needs to know if the widget is in a "configuration state" or not, so that can be removed from both host and provider.
  • Since there is no longer a different between "add" configuration state and "edit" configuration state, we can always show the Save and Cancel buttons in the Configuration template, although we only enable Cancel if there was once a valid state we can return to.
  • Added AddWidgetViewModel to show WidgetDefinition information in the Add Widget dialog.
  • Added the WidgetScreenshotService to the Dashboard, since we need to show the widget preview images ("screenshots") in the Add Widget dialog. We cache the screenshots, but only when they are going to be shown.

PR in Draft while we wait for screenshot assets.

image
image

Validation steps performed

PR checklist

@krschau krschau changed the title Change Widget Pin flow to show preview images, configure on the Dashboard Change Widget Pin flow to show preview images Jan 8, 2024
@dkbennett dkbennett added the Needs-Second Pull request that needs another approval label Jan 11, 2024
@EricJohnson327 EricJohnson327 marked this pull request as ready for review January 11, 2024 20:42
@EricJohnson327 EricJohnson327 merged commit 1bc8749 into main Jan 11, 2024
4 checks passed
@EricJohnson327 EricJohnson327 deleted the user/krschau/pinflow branch January 11, 2024 20:42
@krschau krschau removed the Needs-Second Pull request that needs another approval label Jan 25, 2024
@krschau krschau mentioned this pull request Jan 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Pin Widget flow
3 participants