Adding "open new window" icon to "Create Dev Drive" button (#1334)

[gregalantiu2]

Summary of the pull request

A request was made to clarify that clicking the "Create Dev Drive" button in the "Introducing Dev Home" page view takes you outside the app. @cinnamon-msft suggested that the same icon used in the "Machine Configuration" page should be added to convey this idea.

References and relevant issues

#1334

Detailed description of the pull request / Additional comments

In WhatsNewPage.xaml, some refactoring of the button element occurs. Child elements are added in order to accommodate both text and icon inside the button.

Additionally, I added a boolean property to the WhatsNewCard.cs called ShouldShowIcon which is used to toggle the Visibility property of the icon since currently the "Create Dev Drive" button is the only button we want the icon showing for.

In WhatsNewPage.xaml.cs, logic was added to set ShouldShowIcon to false except for the "Create Dev Drive" button.

Validation steps performed

Manually verified UI renders as expected

PR checklist

• Closes Clarify information and behavior of Dev Drive card on "Introducing Dev Home" page #1334
• Tests added/passed
• Documentation updated

[gregalantiu2]

@gregalantiu2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[gregalantiu2]

Hi @cinnamon-msft , does the image of the updated button look good (spacing, size, location, etc.)? If so, I'll publish this PR. Thanks!

[cinnamon-msft]

I would suggest making the icon a bit smaller to match the font size, but otherwise I think this looks great!

[gregalantiu2]

Yea, that's a great idea - it looks a lot better. I made it the same size (FontSize="12") as the same icon that appears on the "Feedback" settings page
.

More than happy to make more adjustments if need be, just let me know 😄

---

NOTE: Just a heads up, I wanted to give clarity to this:

I amended a commit message which I then had to force-push

[vineeththomasalex]

LGTM!