Pipeline changes to build, publish, and test #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danlegg
commented
Mar 27, 2024
danlegg
commented
- Handcraft NuGet commands to pack and publish
- Run unit tests on Windows-2022 image
getrou
reviewed
Mar 27, 2024
.pipelines/jobs/OneBranchNuGet.yml
Outdated
| buildProperties: 'cppwinrt_exe=$(Build.SourcesDirectory)\x86\cppwinrt\cppwinrt.exe;cppwinrt_fast_fwd_x86=$(Build.SourcesDirectory)\x86\cppwinrt_fast_forwarder.lib;cppwinrt_fast_fwd_x64=$(Build.SourcesDirectory)\x64\cppwinrt_fast_forwarder.lib;cppwinrt_fast_fwd_arm=$(Build.SourcesDirectory)\arm\cppwinrt_fast_forwarder.lib;cppwinrt_fast_fwd_arm64=$(Build.SourcesDirectory)\arm64\cppwinrt_fast_forwarder.lib' | ||
| packDestination: $(ob_outputDirectory)\packages | ||
| command: 'custom' | ||
| arguments: 'pack nuget/Microsoft.Windows.CppWinRT.nuspec -NonInteractive -OutputDirectory $(ob_outputDirectory)\packages -Properties Configuration=release;cppwinrt_exe=C:\__w\1\s\x86\cppwinrt\cppwinrt.exe;cppwinrt_fast_fwd_x86=C:\__w\1\s\x86\cppwinrt_fast_forwarder.lib;cppwinrt_fast_fwd_x64=C:\__w\1\s\x64\cppwinrt_fast_forwarder.lib;cppwinrt_fast_fwd_arm=C:\__w\1\s\arm\cppwinrt_fast_forwarder.lib;cppwinrt_fast_fwd_arm64=C:\__w\1\s\arm64\cppwinrt_fast_forwarder.lib;target_version=$(PackageVersion) -Version $(PackageVersion) -Verbosity Detailed' |
There was a problem hiding this comment.
I think Build.SourcesDirectory would be preferable to "C:/__w/1/s". Was Build.SourcesDirectory not working here? I'm curious about the guid for the task as well, was NuGetCommand@2 not available or working for OneBranch?
DefaultRyan
reviewed
Mar 27, 2024
.pipelines/jobs/OneBranchNuGet.yml
Outdated
| @@ -56,15 +55,11 @@ jobs: | |||
| artifactName: 'drop_build_arm64' | |||
| targetPath: '$(Build.SourcesDirectory)/arm64' | |||
|
|
|||
| - task: NuGetCommand@2 | |||
| - task: 333b11bd-d341-40d9-afcf-b32d5ce6f23b@2 | |||
There was a problem hiding this comment.
Did we change the type of task here, and why is the command changed from 'pack' to 'custom'?
There was a problem hiding this comment.
NuGetCommand@2 works for the custom nuget commands too - I've switched back. Rather than trying to get all the input parameters to play nicely with the task I just used a custom nuget command which I copied out of a working pipeline log.
DefaultRyan
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.