Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Windows 7 support code #1348

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Remove old Windows 7 support code #1348

merged 3 commits into from
Aug 28, 2023

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Aug 25, 2023

As a reminder, whatever Windows 7 compatibility was previously provided is still available via older versions of the C++/WinRT nuget package.

Fixes: #1344

@kennykerr
Copy link
Collaborator Author

kennykerr commented Aug 25, 2023

I've also removed tests that rely on GNU to build since their import libs don't include some Windows 8 exports. We can decide what to ultimately do about that here: #1341

The cppwinrt compiler continues to be cross compiled and both MSVC and Clang are tested on Windows.

@alvinhochun
Copy link
Contributor

alvinhochun commented Aug 26, 2023

I believe the mingw-w64 link errors can be fixed by adding combase to the link libraries.

Edit: It probably should be runtimeobject instead... but will have to test it to be sure.
Yeah probably, I did add that for test and old_tests.

@kennykerr kennykerr merged commit de6ca88 into master Aug 28, 2023
80 checks passed
@kennykerr kennykerr deleted the win7 branch August 28, 2023 13:35
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old Windows 7 support code
3 participants