Allow classic COM interfaces with get_self #1314
Conversation
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
@DefaultRyan can you take a look at this whenever convenient? |
|
The good news is that the OS recently ditched a very very old version of cppwinrt that was only used by Xaml so now there is only one version of cppwinrt in the OS. The bad news is that one newer version is still over a year old, and the later versions introduce build breaks that have thus far prevented updating the OS. Unfortunately, until that is cleared up it won't be easy to update cppwinrt without risking additional delays. Ryan is looking into updating the OS but it may be some time before that's cleared up. |
|
That sounds like a urge ordeal! Hopefully these get resolved soon. In the meantime, is it possible to prevent the stale bot from closing PRs? |
|
I assume you can always reopen the PRs later on if they are closed. And if you just keep commenting on the issue or PR from time to time then it will remain open. |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Bump, waiting on @DefaultRyan's review. |
|
Unfortunately, a project maintainer is not currently available to review this pull request. Please see the contributing guide for more information. Feel free to keep the conversation going on the related issue. |
|
Reopening, will review Monday. Looks great so far. |
|
@jonwis - this change is library-only so its relatively simple to review provided good test coverage. |
|
Any chance at a new release with this fix? |
|
Kicked off a build. |
Fixes #1312