Better toolchain downloader #9941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
665a7fd
to
0e795d9
Compare
0e795d9
to
ccde108
Compare
13 tasks
anphel31
approved these changes
Jul 29, 2024
| echo "-u|--url-list: Space separated list of base URLs to attempt to download the RPM from. The URLs will be tried in order" | ||
| echo " until the RPM is successfully downloaded. Full URL will be <url>/<rpm_name>" | ||
| echo "-c|--certificate: Optional path to a certificate file to use for the download" | ||
| echo "-k|--private-key: Optional path to a private key file to use for the download" |
There was a problem hiding this comment.
does not match usage output above (--key vs --private-key, and --certificate vs --cert)
| --downloader-tool "$(go-downloader)" \ | ||
| --rpm-name "$(notdir $@)" \ | ||
| --dst "$@" \ | ||
| --log-base "$$log_file" \ |
There was a problem hiding this comment.
is this intentional? ($$log_file)
There was a problem hiding this comment.
Yes, its referencing the bash variable $log_file but needs an escape for Make.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
In preparation for a new explicit validation mechanism break out the toolchain downloader logic into a real script.
The new script will handle the logic that was previously baked into the makefile, while also addressing the issue of log overwriting.
Change Log
download_toolchain_rpms.shDoes this affect the toolchain?
YES
Associated issues
Links to CVEs
Test Methodology