-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silences Pip Install Messages in Code Executors #2105
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2105 +/- ##
==========================================
+ Coverage 36.90% 46.79% +9.88%
==========================================
Files 68 68
Lines 7061 7069 +8
Branches 1541 1671 +130
==========================================
+ Hits 2606 3308 +702
+ Misses 4225 3477 -748
- Partials 230 284 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add unit tests to check for the expected behavior?
- input code block contains pip install, package is valid, output is empty
- input code block contains pip install, package is invalid, etc. random strings, output contains error.
See the existing unit tests for jupyter code executor for reference.
* fix * adds tests * check if windows * adds windows shells * modifies exit code * fix powershell --------- Co-authored-by: Eric Zhu <[email protected]>
Why are these changes needed?
Related issue number
Closes #2075
Checks