Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default trigger value for register_nested_chats #1833

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Mar 1, 2024

Why are these changes needed?

The trigger argument must not have default value. Because for every case it requires user to set some specific agent for the trigger. If it were set to any agent, then any nested chat is going to trigger a recursive nested chat.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.56%. Comparing base (0a49f2a) to head (2bafdb2).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1833       +/-   ##
===========================================
+ Coverage   35.69%   54.56%   +18.86%     
===========================================
  Files          63       63               
  Lines        6625     6625               
  Branches     1454     1579      +125     
===========================================
+ Hits         2365     3615     +1250     
+ Misses       4067     2713     -1354     
- Partials      193      297      +104     
Flag Coverage Δ
unittests 54.52% <ø> (+18.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu requested a review from qingyun-wu March 1, 2024 07:24
Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sonichi sonichi added this pull request to the merge queue Mar 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 1, 2024
@sonichi sonichi added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit fcf14ee Mar 1, 2024
53 of 60 checks passed
@sonichi sonichi deleted the nested-chats-trigger branch March 1, 2024 22:38
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* remove default trigger value for register_nested_chats

* update notebook and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants