Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate using None for code_execution_config #1506

Merged

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

As a user I would expect providing a value of None for code_execution_config would disable the feature. It is instead used as a sentinel for the "default" case. This change is the first step in rectifying this confusion.

Related issue number

N/A

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eaf712) 33.08% compared to head (2bb3c31) 53.59%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1506       +/-   ##
===========================================
+ Coverage   33.08%   53.59%   +20.51%     
===========================================
  Files          42       42               
  Lines        5048     5051        +3     
  Branches     1156     1224       +68     
===========================================
+ Hits         1670     2707     +1037     
+ Misses       3250     2112     -1138     
- Partials      128      232      +104     
Flag Coverage Δ
unittests 53.53% <100.00%> (+20.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@afourney afourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonichi sonichi added this pull request to the merge queue Feb 2, 2024
Merged via the queue into microsoft:main with commit 9cd458e Feb 2, 2024
47 of 53 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants