Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for GPT assistant #1505

Merged
merged 8 commits into from
Feb 2, 2024
Merged

Fix tests for GPT assistant #1505

merged 8 commits into from
Feb 2, 2024

Conversation

davorrunje
Copy link
Collaborator

@davorrunje davorrunje commented Feb 1, 2024

Why are these changes needed?

Fixes failing tests for GPT assistant.

Steps to reproduce

Run tests on test/agentchat/contrib/test_gpt_assistant.py

git checkout main
git pull
pytest test/agentchat/contrib/test_gpt_assistant.py

Output:

======================================= test session starts ========================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /workspaces/autogen
configfile: pyproject.toml
plugins: asyncio-0.23.3, anyio-4.2.0
asyncio: mode=strict
collected 7 items                                                                                  

test/agentchat/contrib/test_gpt_assistant.py .....FF                                         [100%]

Related issue number

Closes #1504

Checks

@davorrunje
Copy link
Collaborator Author

@sonichi can you please restart the tests? Everything is working locally.

@sonichi sonichi added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit b0f42a1 Feb 2, 2024
51 of 56 checks passed
@sonichi sonichi deleted the fix-gpt-assistant branch February 2, 2024 16:43
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fixed tests for gpt assistant

* fixed tests for gpt assistant

* api_type openai

* tests updated

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openai-assistant Issues related to assistants from OpenAI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tests are failing for GPT assistant
6 participants