-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function calling upgrade #1443
Function calling upgrade #1443
Conversation
…ations and register_function added to simplify registration of functions without decorators
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
===========================================
+ Coverage 32.69% 45.70% +13.00%
===========================================
Files 42 42
Lines 5019 5039 +20
Branches 1151 1220 +69
===========================================
+ Hits 1641 2303 +662
+ Misses 3248 2552 -696
- Partials 130 184 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In notebooks, when calling initiate_chat
and a_initiate_chat
we can use the with Cache.disk() as cache
context to make user aware of the cache feature. So we can gradually get rid of the legacy cache_seed setting in llm_config.
I guess the test failure is due to a recent change #1471 |
Yes. Just remove the "Tool Call Id: ...\n" lines from the content fields of the test. |
Yup, that was it. Thanx! |
* function calling upgraded: async/sync mixing works now for all combinations and register_function added to simplify registration of functions without decorators * polishing * fixing tests --------- Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
Two improvements related to recent feedback from Discord:
register_function
was added to simplify the registration of functions without decorators.Related issue number
Checks