Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenstudio - Add GroupChat Support to UI #1352

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Autogenstudio - Add GroupChat Support to UI #1352

merged 4 commits into from
Jan 23, 2024

Conversation

victordibia
Copy link
Collaborator

Why are these changes needed?

Add support for GroupChat, and other quality of life improvements to autogenstudio

groupchatnew.mp4

Related issue number

#1285 #1265 #1294 #1296

Checks

@victordibia victordibia requested a review from gagb January 21, 2024 07:19
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d243db7) 32.48% compared to head (b5273a3) 32.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   32.48%   32.48%           
=======================================
  Files          41       41           
  Lines        4907     4907           
  Branches     1120     1120           
=======================================
  Hits         1594     1594           
  Misses       3187     3187           
  Partials      126      126           
Flag Coverage Δ
unittests 32.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victordibia victordibia marked this pull request as ready for review January 21, 2024 07:23
samples/apps/autogen-studio/autogenstudio/web/app.py Dismissed Show dismissed Hide dismissed
samples/apps/autogen-studio/autogenstudio/web/app.py Dismissed Show dismissed Hide dismissed
samples/apps/autogen-studio/autogenstudio/web/app.py Dismissed Show dismissed Hide dismissed
@gagb
Copy link
Collaborator

gagb commented Jan 21, 2024

@victordibia are you able to build this PR in the studio devcontainer and get autogenstudio ui to succeed?

@victordibia
Copy link
Collaborator Author

@gagb , I just tried this and I am able to run the studio devcontainer. and autogenstudio ui runs once the devcontainer loads. Are you seeing any issues?

Copy link

@reconsumeralization reconsumeralization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end.

@gagb
Copy link
Collaborator

gagb commented Jan 22, 2024

@gagb , I just tried this and I am able to run the studio devcontainer. and autogenstudio ui runs once the devcontainer loads. Are you seeing any issues?

I haven't tried today but when I tested yesterday, in the studio container the autogenstudio ui command runs, but once I try to interact with the webpage (which it opens via a port redirect) the webpage encounters many error messages (toasts). I will have time to test again tomorrow morning. Did that correctly work for you?

@victordibia
Copy link
Collaborator Author

@gagb , I just tried this and I am able to run the studio devcontainer. and autogenstudio ui runs once the devcontainer loads. Are you seeing any issues?

I haven't tried today but when I tested yesterday, in the studio container the autogenstudio ui command runs, but once I try to interact with the webpage (which it opens via a port redirect) the webpage encounters many error messages (toasts). I will have time to test again tomorrow morning. Did that correctly work for you?

Thanks. I'll test again, but If you can share the exact toast errors (e.g., if it is an api key thing .. ), it would be helpful

@gagb
Copy link
Collaborator

gagb commented Jan 23, 2024

@gagb , I just tried this and I am able to run the studio devcontainer. and autogenstudio ui runs once the devcontainer loads. Are you seeing any issues?

I haven't tried today but when I tested yesterday, in the studio container the autogenstudio ui command runs, but once I try to interact with the webpage (which it opens via a port redirect) the webpage encounters many error messages (toasts). I will have time to test again tomorrow morning. Did that correctly work for you?

Thanks. I'll test again, but If you can share the exact toast errors (e.g., if it is an api key thing .. ), it would be helpful

I am no longer seeing the toast errors! I am not sure what changed.

But I am still seeing interactions that feel buggy for creating a simple chatgpt like experience -- I can meet 1-1 and show. Some of these are related to adding default params models and agents that do not exist. Why is min max consecutive replies set to 2?

Would be worth addressing these in a separate PR.

@sonichi sonichi added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 30b84d4 Jan 23, 2024
22 checks passed
mtwalther pushed a commit to mtwalther/autogen that referenced this pull request Jan 26, 2024
* support groupchat, other QOL fixes

* remove gallery success toast

* Update website/blog/2023-12-01-AutoGenStudio/index.mdx

Co-authored-by: Chi Wang <[email protected]>

---------

Co-authored-by: Chi Wang <[email protected]>
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
* support groupchat, other QOL fixes

* remove gallery success toast

* Update website/blog/2023-12-01-AutoGenStudio/index.mdx

Co-authored-by: Chi Wang <[email protected]>

---------

Co-authored-by: Chi Wang <[email protected]>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* support groupchat, other QOL fixes

* remove gallery success toast

* Update website/blog/2023-12-01-AutoGenStudio/index.mdx

Co-authored-by: Chi Wang <[email protected]>

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants