Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove errors if noEmit is sepcified with noCheck or emitDeclarationOnly #59071

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Remove errors if noEmit is sepcified with noCheck or emitDeclarationOnly #59071

merged 2 commits into from
Jun 28, 2024

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jun 28, 2024 •
edited
Loading

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 28, 2024
jakebailey
jakebailey approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@sheetalkamat sheetalkamat merged commit cb98634 into main Jun 28, 2024
29 checks passed
@sheetalkamat sheetalkamat deleted the noEmitAndNoCheck branch June 28, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@weswigham weswigham Awaiting requested review from weswigham

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sheetalkamat @jakebailey @typescript-bot