Fix: False Positive "Range out of order in character class" in Regular Expressions in Unicode Modes #58982

graphemecluster · 2024-06-23T21:53:20Z

The first appears to be my fault; the second is a regression of #58339.

…r Expressions in Unicode Modes

typescript-bot · 2024-06-23T21:53:24Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

sandersn

The first change seems like a straightforward fix. @rbuckton does the second change make sense?

sandersn · 2024-07-09T21:47:24Z

@graphemecluster can you provide a link to a bug or at least the PR that caused the bug for the first fix?

graphemecluster · 2024-07-09T22:53:48Z

@sandersn
First: https://github.com/microsoft/TypeScript/pull/55600/files#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506R1587
Second: https://github.com/microsoft/TypeScript/pull/58339/files?w=1#diff-e19070e6b0ecc4de5f7d4bc6b42a9a71c8f23ce8ce155f7bd7cd48763170e506R3462

sandersn · 2024-07-10T22:41:39Z

@typescript-bot test all

sandersn · 2024-07-10T22:42:56Z

@typescript-bot test it

typescript-bot · 2024-07-10T22:42:59Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-10T23:04:58Z

Hey @sandersn, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-10T23:09:50Z

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/58982/merge:

Everything looks good!

typescript-bot · 2024-07-10T23:19:27Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,971k (± 1.01%)}	_{193,975k (± 1.01%)}	_~	_192,162k	_195,895k	_{p=0.810 n=6}
_{Parse Time}	_{1.57s (± 0.99%)}	_{1.57s (± 0.66%)}	_~	_1.56s	_1.58s	_{p=0.793 n=6}
_{Bind Time}	_{0.85s (± 1.37%)}	_{0.85s (± 0.96%)}	_~	_0.84s	_0.86s	_{p=0.738 n=6}
_{Check Time}	_{11.24s (± 0.26%)}	_{11.23s (± 0.45%)}	_~	_11.13s	_11.27s	_{p=1.000 n=6}
_{Emit Time}	_{3.27s (± 0.84%)}	_{3.27s (± 0.76%)}	_~	_3.24s	_3.31s	_{p=0.872 n=6}
_{Total Time}	_{16.93s (± 0.23%)}	_{16.92s (± 0.37%)}	_~	_16.83s	_17.01s	_{p=0.748 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,390k (± 0.01%)}	_{1,218,389k (± 0.00%)}	_~	_1,218,337k	_1,218,472k	_{p=1.000 n=6}
_{Parse Time}	_{8.01s (± 0.33%)}	_{8.01s (± 0.64%)}	_~	_7.96s	_8.10s	_{p=0.560 n=6}
_{Bind Time}	_{2.21s (± 0.38%)}	_{2.21s (± 0.23%)}	_~	_2.21s	_2.22s	_{p=0.923 n=6}
_{Check Time}	_{35.71s (± 0.22%)}	_{35.88s (± 0.35%)}	_{+0.17s (+ 0.47%)}	_35.70s	_36.00s	_{p=0.045 n=6}
_{Emit Time}	_{16.11s (± 0.22%)}	_{16.14s (± 0.56%)}	_~	_16.02s	_16.29s	_{p=0.521 n=6}
_{Total Time}	_{62.05s (± 0.14%)}	_{62.24s (± 0.22%)}	_{+0.19s (+ 0.31%)}	_62.12s	_62.46s	_{p=0.016 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,130,296	_2,130,296	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,656	_927,656	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,106,998k (± 0.01%)}	_{2,107,103k (± 0.00%)}	_~	_2,106,992k	_2,107,208k	_{p=0.298 n=6}
_{Parse Time}	_{9.63s (± 0.52%)}	_{9.67s (± 0.39%)}	_~	_9.61s	_9.72s	_{p=0.229 n=6}
_{Bind Time}	_{3.37s (± 0.62%)}	_{3.37s (± 0.52%)}	_~	_3.34s	_3.38s	_{p=0.871 n=6}
_{Check Time}	_{101.37s (± 1.94%)}	_{102.47s (± 0.37%)}	_~	_101.86s	_102.90s	_{p=0.173 n=6}
_{Emit Time}	_{0.76s (±122.23%)}	_{0.19s (± 2.81%)}	_~	_0.19s	_0.20s	_{p=0.663 n=6}
_{Total Time}	_{115.13s (± 1.02%)}	_{115.71s (± 0.33%)}	_~	_115.10s	_116.09s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,970	_1,225,970	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,580	_261,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,338,862k (± 0.02%)}	_{2,339,354k (± 0.05%)}	_~	_2,338,021k	_2,341,110k	_{p=0.575 n=6}
_{Parse Time}	_{6.07s (± 0.70%)}	_{6.06s (± 0.82%)}	_~	_5.99s	_6.12s	_{p=0.809 n=6}
_{Bind Time}	_{2.25s (± 0.52%)}	_{2.25s (± 0.36%)}	_~	_2.24s	_2.26s	_{p=0.622 n=6}
_{Check Time}	_{40.17s (± 0.23%)}	_{40.27s (± 0.24%)}	_~	_40.18s	_40.44s	_{p=0.066 n=6}
_{Emit Time}	_{3.84s (± 1.78%)}	_{3.85s (± 1.73%)}	_~	_3.79s	_3.96s	_{p=0.521 n=6}
_{Total Time}	_{52.35s (± 0.14%)}	_{52.45s (± 0.28%)}	_~	_52.26s	_52.67s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,970	_1,225,970	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,580	_261,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,413,576k (± 0.02%)}	_{2,412,733k (± 0.03%)}	_~	_2,411,626k	_2,413,811k	_{p=0.109 n=6}
_{Parse Time}	_{7.86s (± 0.55%)}	_{7.87s (± 1.22%)}	_~	_7.71s	_7.97s	_{p=0.521 n=6}
_{Bind Time}	_{2.52s (± 1.61%)}	_{2.49s (± 1.17%)}	_~	_2.46s	_2.54s	_{p=0.172 n=6}
_{Check Time}	_{50.18s (± 0.22%)}	_{50.26s (± 0.33%)}	_~	_49.95s	_50.42s	_{p=0.298 n=6}
_{Emit Time}	_{4.82s (± 1.56%)}	_{4.85s (± 2.18%)}	_~	_4.74s	_4.98s	_{p=0.688 n=6}
_{Total Time}	_{65.39s (± 0.17%)}	_{65.49s (± 0.26%)}	_~	_65.25s	_65.73s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,280	_258,280	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,782	_104,782	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,150k (± 0.01%)}	_{427,180k (± 0.02%)}	_~	_427,071k	_427,271k	_{p=0.575 n=6}
_{Parse Time}	_{4.10s (± 0.39%)}	_{4.09s (± 0.53%)}	_~	_4.07s	_4.13s	_{p=0.607 n=6}
_{Bind Time}	_{1.62s (± 1.43%)}	_{1.63s (± 1.00%)}	_~	_1.60s	_1.65s	_{p=0.682 n=6}
_{Check Time}	_{22.01s (± 0.37%)}	_{22.02s (± 0.33%)}	_~	_21.94s	_22.10s	_{p=1.000 n=6}
_{Emit Time}	_{2.03s (± 1.02%)}	_{2.04s (± 0.86%)}	_~	_2.01s	_2.06s	_{p=0.123 n=6}
_{Total Time}	_{29.75s (± 0.31%)}	_{29.79s (± 0.31%)}	_~	_29.68s	_29.90s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,444k (± 0.01%)}	_{369,522k (± 0.03%)}	_~	_369,419k	_369,695k	_{p=0.173 n=6}
_{Parse Time}	_{2.77s (± 1.23%)}	_{2.76s (± 0.42%)}	_~	_2.74s	_2.77s	_{p=0.418 n=6}
_{Bind Time}	_{1.58s (± 0.87%)}	_{1.58s (± 0.35%)}	_~	_1.57s	_1.58s	_{p=0.235 n=6}
_{Check Time}	_{15.48s (± 0.38%)}	_{15.50s (± 0.40%)}	_~	_15.40s	_15.57s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.83s (± 0.47%)}	_{19.83s (± 0.37%)}	_~	_19.73s	_19.92s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,889,439	_2,889,439	_~	_~	_~	_{p=1.000 n=6}
_Types	_977,632	_977,632	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,052,934k (± 0.00%)}	_{3,052,920k (± 0.00%)}	_~	_3,052,851k	_3,053,029k	_{p=0.575 n=6}
_{Parse Time}	_{13.70s (± 0.41%)}	_{13.72s (± 0.43%)}	_~	_13.61s	_13.78s	_{p=0.686 n=6}
_{Bind Time}	_{4.21s (± 0.37%)}	_{4.23s (± 0.37%)}	_~	_4.21s	_4.25s	_{p=0.078 n=6}
_{Check Time}	_{75.85s (± 2.84%)}	_{74.11s (± 0.62%)}	_~	_73.58s	_74.82s	_{p=0.298 n=6}
_{Emit Time}	_{22.03s (± 9.71%)}	_{23.96s (± 0.38%)}	_~	_23.81s	_24.06s	_{p=0.230 n=6}
_{Total Time}	_{115.79s (± 0.23%)}	_{116.03s (± 0.38%)}	_~	_115.56s	_116.60s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,235	_267,235	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,815	_108,815	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,818k (± 0.01%)}	_{411,823k (± 0.02%)}	_~	_411,745k	_411,930k	_{p=0.689 n=6}
_{Parse Time}	_{4.75s (± 0.49%)}	_{4.74s (± 0.59%)}	_~	_4.71s	_4.78s	_{p=0.683 n=6}
_{Bind Time}	_{2.08s (± 0.71%)}	_{2.08s (± 0.58%)}	_~	_2.07s	_2.10s	_{p=0.616 n=6}
_{Check Time}	_{20.74s (± 0.21%)}	_{20.75s (± 0.29%)}	_~	_20.69s	_20.86s	_{p=0.870 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.56s (± 0.22%)}	_{27.58s (± 0.32%)}	_~	_27.49s	_27.73s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,050	_510,050	_~	_~	_~	_{p=1.000 n=6}
_Types	_161,597	_161,597	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,405k (± 0.06%)}	_{447,382k (± 0.08%)}	_~	_446,971k	_447,895k	_{p=0.810 n=6}
_{Parse Time}	_{3.88s (± 0.40%)}	_{3.89s (± 0.66%)}	_~	_3.85s	_3.92s	_{p=0.685 n=6}
_{Bind Time}	_{1.48s (± 0.66%)}	_{1.47s (± 1.27%)}	_~	_1.45s	_1.49s	_{p=0.156 n=6}
_{Check Time}	_{21.08s (± 0.52%)}	_{21.12s (± 0.33%)}	_~	_21.01s	_21.20s	_{p=0.574 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{26.45s (± 0.43%)}	_{26.47s (± 0.36%)}	_~	_26.36s	_26.61s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-11T00:22:50Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58982/merge:

Everything looks good!

Fix: False Positive "Range out of order in character class" in Regula…

94ead1b

…r Expressions in Unicode Modes

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 23, 2024

sandersn reviewed Jul 9, 2024

View reviewed changes

sandersn assigned rbuckton Jul 9, 2024

sandersn requested a review from rbuckton July 9, 2024 21:47

rbuckton approved these changes Jul 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: False Positive "Range out of order in character class" in Regular Expressions in Unicode Modes #58982

Fix: False Positive "Range out of order in character class" in Regular Expressions in Unicode Modes #58982

graphemecluster commented Jun 23, 2024

typescript-bot commented Jun 23, 2024

sandersn left a comment

sandersn commented Jul 9, 2024

graphemecluster commented Jul 9, 2024

sandersn commented Jul 10, 2024

sandersn commented Jul 10, 2024

typescript-bot commented Jul 10, 2024 •

edited

Loading

typescript-bot commented Jul 10, 2024

typescript-bot commented Jul 10, 2024

typescript-bot commented Jul 10, 2024

tsc

typescript-bot commented Jul 11, 2024

Fix: False Positive "Range out of order in character class" in Regular Expressions in Unicode Modes #58982

Are you sure you want to change the base?

Fix: False Positive "Range out of order in character class" in Regular Expressions in Unicode Modes #58982

Conversation

graphemecluster commented Jun 23, 2024

typescript-bot commented Jun 23, 2024

sandersn left a comment

Choose a reason for hiding this comment

sandersn commented Jul 9, 2024

graphemecluster commented Jul 9, 2024

sandersn commented Jul 10, 2024

sandersn commented Jul 10, 2024

typescript-bot commented Jul 10, 2024 • edited Loading

typescript-bot commented Jul 10, 2024

typescript-bot commented Jul 10, 2024

typescript-bot commented Jul 10, 2024

tsc

typescript-bot commented Jul 11, 2024

typescript-bot commented Jul 10, 2024 •

edited

Loading