fix(58955): @import JSDoc tag doesn't seem to account for resolution-mode import attribute in TS v5.5.2 #58966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
jakebailey
approved these changes
Jun 24, 2024
|
@typescript-bot cherry-pick to release-5.5 |
|
Hey, @andrewbranch! I was unable to cherry-pick this PR. Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/9650506935 |
|
I expect cherry-picking to fail just because these lines are ones that changed in the 5.5 bump for type predicate inference... |
|
@jakebailey should I make a new PR to the release branch? |
|
No worries, I'll do it. |
jakebailey
pushed a commit
to jakebailey/TypeScript
that referenced
this pull request
Jun 24, 2024
…mode import attribute in TS v5.5.2 (microsoft#58966)
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 26, 2024
Co-authored-by: Oleksandr T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58955