Make canUseWatchEvents test framework more generic so we can add more tests easily #58962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
Jun 24, 2024
Comment on lines
+102
to
+104
| session.host.windowsStyleRoot ? | ||
| path.win32.resolve(fileName) : | ||
| path.posix.resolve(fileName), |
There was a problem hiding this comment.
Is this path just used for debug logging? Surprised to see node's real path lib being used here, but tests do pass...
There was a problem hiding this comment.
Ye this is testing part - where clients like vscode will send win32 like paths instead of normalized so this is testing only
There was a problem hiding this comment.
Ah, okay; I think I was just worried about this resolving via a real path on disk like cwd.
jakebailey
approved these changes
Jun 25, 2024
Comment on lines
+102
to
+104
| session.host.windowsStyleRoot ? | ||
| path.win32.resolve(fileName) : | ||
| path.posix.resolve(fileName), |
There was a problem hiding this comment.
Ah, okay; I think I was just worried about this resolving via a real path on disk like cwd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.