Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-mutating Array methods to es2023 in the lib/target suggestion list #58951

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

DanielRosenwasser
Copy link
Member

A developer upgraded to TypeScript 5.5 and was confused when toSorted was no longer available when compiling. This was because toSorted (along with toReversed, toSpliced, and with) were moved from esnext.array to es2023.array.

This PR makes it so that we recommend es2023 appropriately.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 20, 2024
@DanielRosenwasser DanielRosenwasser changed the title Add non-mutating methods to es2023 in the lib/target the suggestion list Add non-mutating Array methods to es2023 in the lib/target the suggestion list Jun 20, 2024
@DanielRosenwasser DanielRosenwasser changed the title Add non-mutating Array methods to es2023 in the lib/target the suggestion list Add non-mutating Array methods to es2023 in the lib/target suggestion list Jun 20, 2024
@DanielRosenwasser DanielRosenwasser merged commit 327bd09 into main Jun 20, 2024
28 checks passed
@DanielRosenwasser DanielRosenwasser deleted the es2023ArrayMethodSuggestions branch June 20, 2024 23:11
@DanielRosenwasser
Copy link
Member Author

This might be nice to back-port if we have other patch-worthy stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants