Improve @implements error
#58904
Open
Improve @implements error
#58904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make @implements/@extends parse its expression with `parseLeftHandSideExpressionOrHigher` instead of `parsePropertyAccessEntityNameExpression`. This turns many more parse errors into grammar errors, just like in TS. I kept `parseExpressionWithTypeArgumentsForJSDoc` as a separate function in order to keep parsing asterisks -- and `@implements` still only supports a single interface, unlike TS which supports a list of them. Fixes microsoft#58542
typescript-bot
added
Author: Team
For Milestone Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
jakebailey
reviewed
Jun 19, 2024
| readonly class: ExpressionWithTypeArguments & { readonly expression: Identifier | PropertyAccessEntityNameExpression; }; | ||
| readonly class: ExpressionWithTypeArguments; |
There was a problem hiding this comment.
Are these types wrong and that's why they're changing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
@implements/@extendsparse its expression withparseLeftHandSideExpressionOrHigherinstead ofparsePropertyAccessEntityNameExpression. This turns many more parse errors into grammar errors, just like in TS. I keptparseExpressionWithTypeArgumentsForJSDocas a separate function in order to keep parsing asterisks -- and@implementsstill only supports a single interface, unlike TS which supports a list of them.This changes the public API, making the
expressionproperty a supertype of what it used to be. The one change it required in our codebase is in checker.ts. I think it's fine because the code to handle jsdoc@implementsshould really be the same as for TS, which already usesExpressionWithTypeArguments.Fixes #58542