Specialize the message on JSX tags looking for the JSX factory namespace #58870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Should we do something similar for the error message in https://github.dev/microsoft/TypeScript/blob/b1c52c53cc6c8cf35b19accfc3e29916489c821e/src/compiler/checker.ts#L33073? |
|
Yes, probably! |
|
@gabritto done! |
weswigham
reviewed
Jun 18, 2024
| "category": "Error", | ||
| "code": 2869 | ||
| }, | ||
| "This JSX tag requires the module path '{0}' to exist, but none could be found. Make sure you have the appropriate package installed.": { |
There was a problem hiding this comment.
Suggested change
| "This JSX tag requires the module path '{0}' to exist, but none could be found. Make sure you have the appropriate package installed.": { | |
| "This JSX tag requires the module path '{0}' to exist, but none could be found. Make sure you have types for the appropriate package installed.": { | |
? Since it's perfectly possible (common, even) to have react installed, but @types/react is still missing. Or is that a different error?
There was a problem hiding this comment.
Whether there's a separate error, I'm not sure about - but good call on specializing the message.
gabritto
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.