Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report updateGraph time in async requests (that is getErr) as well as part of request completed event #58845

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jun 12, 2024

I think this was over site when we added this to Respose and forgot about "getErr" being async request

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 12, 2024
@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary.

@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@sheetalkamat sheetalkamat requested a review from mjbvz June 12, 2024 21:42
@sheetalkamat
Copy link
Member Author

@mjbvz I am not sure if we need this or not because as I looked into vscode code, currently this is logged into telemetry for all requests but just for completions.
Not sure if this is interesting and useful or not. This came up when @gabritto and i were discussing reporting duration of diagnostic event.

@gabritto gabritto marked this pull request as ready for review June 21, 2024 17:48
@sheetalkamat sheetalkamat merged commit 600dde8 into main Jun 21, 2024
28 checks passed
@sheetalkamat sheetalkamat deleted the performanceData branch June 21, 2024 19:52
sheetalkamat added a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants