-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed intersections of primitive unions with exactOptionalPropertyTypes
when mixing undefinedType
with missingType
#58186
Fixed intersections of primitive unions with exactOptionalPropertyTypes
when mixing undefinedType
with missingType
#58186
Conversation
…pes` when mixing `undefinedType` with `missingType`
@typescript-bot test it |
Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! |
@jakebailey Here are the results of running the user tests comparing Everything looks good! |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@jakebailey Here are the results of running the top 400 repos comparing Everything looks good! |
src/compiler/checker.ts
Outdated
if (t === missingType && result.length && result[0] === undefinedType) { | ||
result[0] = missingType; | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this PR as test for some new code coverage stuff, and it actually revealed that this code is never tested: https://app.codecov.io/gh/jakebailey/TypeScript-codecov-testing/pull/3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed out a new test case and verified manually that those lines are hit now
@typescript-bot pack this |
Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
fixes #58174