[wip] Type acquisition and module resolution updates #56074
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
sheetalkamat
force-pushed
the
unresolvedImports
branch
11 times, most recently
from
d89c3a2
to
bbb8540
Compare
sheetalkamat
force-pushed
the
unresolvedImports
branch
4 times, most recently
from
e6d920c
to
a79e9b9
Compare
sheetalkamat
force-pushed
the
unresolvedImports
branch
4 times, most recently
from
bf027a7
to
2e71217
Compare
sheetalkamat
force-pushed
the
unresolvedImports
branch
from
2e71217
to
59f0d22
Compare
sheetalkamat
force-pushed
the
unresolvedImports
branch
2 times, most recently
from
ec26f33
to
18cd5c6
Compare
sheetalkamat
force-pushed
the
unresolvedImports
branch
3 times, most recently
from
d7e5cb8
to
b5d2968
Compare
sheetalkamat
force-pushed
the
unresolvedImports
branch
2 times, most recently
from
ab0752f
to
520814f
Compare
sheetalkamat
force-pushed
the
unresolvedImports
branch
4 times, most recently
from
9a7b1a4
to
95fe885
Compare
First unresolved import gets the typing file into cache and sets it as root, This results in scheduling new typing request with that unresolved import missing The result will come back with typing file that is omitted, so root file will change but file will still be part of program so its not really removed from program
Also cache the inferred type acquition for inferred project
…ypings cache This change finally makes all tests pass incremental tests for matching resolutions and program structuture
…pass, invalidate them at usage site
…eed to update last cached unresolved imports just because we have new program
sheetalkamat
force-pushed
the
unresolvedImports
branch
from
95fe885
to
10165f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working, creating PR to run tests
Fixes #