error on variables that are used but never initialized #55887
Conversation
|
The TypeScript team hasn't accepted the linked issue #23305. If you can get it accepted, this PR will have a better chance of being reviewed. |
src/compiler/checker.ts
Outdated
| @@ -2147,7 +2147,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| var deferredGlobalClassAccessorDecoratorResultType: GenericType | undefined; | |||
| var deferredGlobalClassFieldDecoratorContextType: GenericType | undefined; | |||
|
|
|||
| var allPotentiallyUnusedIdentifiers = new Map<Path, PotentiallyUnusedIdentifier[]>(); // key is file name | |||
| var allPotentiallyUnusedOrUninitializedIdentifiers = new Map<Path, PotentiallyUnusedIdentifier[]>(); // key is file name | |||
There was a problem hiding this comment.
Will allLocalIdentifiers be a better variable name?
I assume you meant “initialized” here. |
Zzzen
changed the title
src/compiler/types.ts
Outdated
| @@ -5765,6 +5765,7 @@ export interface Symbol { | |||
| /** @internal */ exportSymbol?: Symbol; // Exported symbol associated with this symbol | |||
| /** @internal */ constEnumOnlyModule: boolean | undefined; // True if module contains only const enums or other modules with only const enums | |||
| /** @internal */ isReferenced?: SymbolFlags; // True if the symbol is referenced elsewhere. Keeps track of the meaning of a reference in case a symbol is both a type parameter and parameter. | |||
| /** @internal */ isInitialized?: boolean; // True if the symbol is ever initialized. | |||
There was a problem hiding this comment.
If this is set in the checker, it probably shouldn't be directly set on the Symbol (and should be set on SymbolLinks instead). Maybe someone else has some thoughts.
There was a problem hiding this comment.
Alternatively, can you just use isAssigned (defined below) which is set in the binder? You'll need to change some existing code to proactively check for whether the symbol also corresponds to a parameter.
There was a problem hiding this comment.
Based on perf, this is making the Symbol allocated in the next size class up, which is undesirable. So probably on links.
There was a problem hiding this comment.
Can't we just reuse isAssigned?
There was a problem hiding this comment.
Updated. It's totally fine to reuse isAssigned.
|
@typescript-bot pack this |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at ff025b3. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at ff025b3. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at ff025b3. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at ff025b3. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at ff025b3. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at ff025b3. You can monitor the build here. Update: The results are in! |
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
|
@DanielRosenwasser Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
@DanielRosenwasser Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Hm, perf result indicates that adding this prop has moved Symbol into a new size class, given the memory increase. |
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. DetailsServer exited prematurely with code unknown and signal SIGABRTAffected reposcalcom/cal.comRaw error text:RepoResults7/calcom.cal.com.rawError.txt in the artifact folder
Last few requests{"seq":728,"type":"request","command":"navto","arguments":{"searchValue":"a","maxResultCount":256}}
{"seq":729,"type":"request","command":"navto","arguments":{"searchValue":"a1R","maxResultCount":256}}
{"seq":730,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/apps/api/test/lib/bookings/_post.test.ts"],"openFiles":[]}}
{"seq":731,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/apps/web/components/AppListCard.tsx","projectRootPath":"@PROJECT_ROOT@"}]}}
Repro steps
|
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
|
I spent a bit looking at the breaks and decided to take a break. There was one example of a TODO which is questionable - I didn't quite understand that. For the most part, in the top 300 TypeScript projects on GitHub, the only real false negatives are variables that get assigned in a |
|
Just to be clear: "False negative" in this context means "this should be an error but isn't", correct? I'm a little confused by the |
| @@ -13,7 +13,7 @@ | |||
| // for (<|var { [|property1|]: p1 } of elems|>) { | |||
| // } | |||
| // var p2; | |||
| // for (<|{ [|{| isWriteAccess: true |}property1|] : p2 } of elems|>) { | |||
| // for (<|{ [|property1|] : p2 } of elems|>) { | |||
There was a problem hiding this comment.
Could anyone please explain the meaning of "isWriteAccess" in this context? Additionally, I'm curious to know if this qualifies as a regression.
There was a problem hiding this comment.
in find-all-references, we can indicate that certain references are writes so that editors can filter reads and writes out, or display them differently. Technically this is correct as property1 s not being written to - p2 is.
There was a problem hiding this comment.
Though I wonder if p2 has isWriteAccess on it.
It has been fixed. I'm also curious why they were written in this manner. |
Sorry, I meant false positives. I gotta stop trying to sound smarter than I am. What I mean to say is we shouldn't error on the |
|
I'm a little bit concerned that we aren't guarding previous accesses of @typescript-bot pack this |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 8d814cd. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 8d814cd. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at 8d814cd. You can monitor the build here. Update: The results are in! |
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@DanielRosenwasser Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
After conducting some research, it appears that the parent.kind === SyntaxKind.Parameter && isSymbolAssigned(symbol)
isParameter && !isSymbolAssigned(localOrExportSymbol)
isParameterOrCatchClauseVariable(symbol) && !isSymbolAssigned(symbol) |
|
@typescript-bot test top800 |
|
@DanielRosenwasser Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@DanielRosenwasser Here are the results of running the top 800 repos comparing Something interesting changed - please have a look. Details
|
Fixes #23305