Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mediation: "conditional" available #1497

Merged

Conversation

8ma10s
Copy link
Contributor

@8ma10s 8ma10s commented Feb 6, 2023

Since we couldn't merge #1454 due to errors, reopening a fresh PR

8ma10s and others added 2 commits February 6, 2023 19:14
`PublicKeyCredential.isConditionalMediationAvailable()` method is already available, `mediation` field's value `"conditional"` should also be available now.
https://github.com/microsoft/TypeScript-DOM-lib-generator/blob/0337998b669df62d10f3acb96cc2f7c2382bbfda/baselines/dom.generated.d.ts#L11245
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@8ma10s 8ma10s changed the title Make mediation conditional available Make mediation: "conditional" available Feb 6, 2023
@saschanaz
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 378951e into microsoft:main Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants