Add async iterable flavors #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
MattiasBuelens
force-pushed
the
async-iterable
branch
from
eb317d5
to
87e4cdc
Compare
MattiasBuelens
commented
Sep 18, 2022
saschanaz
reviewed
Sep 18, 2022
| "iterator": { | ||
| "type": { | ||
| "0": { | ||
| "overrideType": "R" |
There was a problem hiding this comment.
This seems redundant here.
There was a problem hiding this comment.
Fair enough. I'll need to remember to add it back once browsers actually add support for this async iterator, and it actually ends up in the generated types. 😛
There was a problem hiding this comment.
Hmmmmm. That said, this is the only needed manual data and we know it will eventually come, so maybe we can keep this 👀
| const asyncIterators = emitWebIdl(exposed, options.global[0], "async"); | ||
| await fs.writeFile( | ||
| new URL( | ||
| `${options.name}.asynciterable.generated.d.ts`, |
There was a problem hiding this comment.
I'm not a fan of having extra files, but I guess we need it 🥲
|
Thanks! LGTM. |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
async iterabledeclarations per Web IDL, and emit them as.asynciterable.d.tsflavors. This is a first step towards microsoft/TypeScript#29867.At the time of writing, only
FileSystemDirectoryHandle's async iterator is supported by two browser engines (Chrome and Safari).ReadableStream's async iterator is not implemented anywhere yet, and gets correctly filtered out bygetRemovalData().Fixes part of #1393.