Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LICENSE of published packages #1381

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

jakebailey
Copy link
Member

The license on this repo is Apache 2.0, and we also prepend an Apache 2.0 copyright header onto these files when distributed with TypeScript. But, when the packages like @types/web were introduced, they were instead shipped with the MIT license, which isn't the right one for this code.

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all intents and purposes, I don't think it matters to most consumers. This was likely an oversight, but for consistency we should align with whatever lib.d.ts already ships as within TypeScript. Otherwise this will cause more issues down the line.

@jakebailey jakebailey merged commit fc5fe1a into microsoft:main Aug 18, 2022
@jakebailey jakebailey deleted the fix-package-licenses branch August 18, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants