Disallow clearing timers without no argument at all (#1330)

Co-authored-by: saschanaz <[email protected]>
microsoft · May 15, 2022 · 9e13665 · 9e13665
1 parent cf49d9e
commit 9e13665
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 16 deletions.
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -16670,8 +16670,8 @@ interface WindowOrWorkerGlobalScope {
  readonly performance: Performance;
  atob(data: string): string;
  btoa(data: string): string;
- clearInterval(id?: number): void;
- clearTimeout(id?: number): void;
+ clearInterval(id: number | undefined): void;
+ clearTimeout(id: number | undefined): void;
  createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -17978,8 +17978,8 @@ declare var origin: string;
 declare var performance: Performance;
 declare function atob(data: string): string;
 declare function btoa(data: string): string;
-declare function clearInterval(id?: number): void;
-declare function clearTimeout(id?: number): void;
+declare function clearInterval(id: number | undefined): void;
+declare function clearTimeout(id: number | undefined): void;
 declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

diff --git a/baselines/serviceworker.generated.d.ts b/baselines/serviceworker.generated.d.ts
@@ -5116,8 +5116,8 @@ interface WindowOrWorkerGlobalScope {
  readonly performance: Performance;
  atob(data: string): string;
  btoa(data: string): string;
- clearInterval(id?: number): void;
- clearTimeout(id?: number): void;
+ clearInterval(id: number | undefined): void;
+ clearTimeout(id: number | undefined): void;
  createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5488,8 +5488,8 @@ declare var origin: string;
 declare var performance: Performance;
 declare function atob(data: string): string;
 declare function btoa(data: string): string;
-declare function clearInterval(id?: number): void;
-declare function clearTimeout(id?: number): void;
+declare function clearInterval(id: number | undefined): void;
+declare function clearTimeout(id: number | undefined): void;
 declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

diff --git a/baselines/sharedworker.generated.d.ts b/baselines/sharedworker.generated.d.ts
@@ -4969,8 +4969,8 @@ interface WindowOrWorkerGlobalScope {
  readonly performance: Performance;
  atob(data: string): string;
  btoa(data: string): string;
- clearInterval(id?: number): void;
- clearTimeout(id?: number): void;
+ clearInterval(id: number | undefined): void;
+ clearTimeout(id: number | undefined): void;
  createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5502,8 +5502,8 @@ declare var origin: string;
 declare var performance: Performance;
 declare function atob(data: string): string;
 declare function btoa(data: string): string;
-declare function clearInterval(id?: number): void;
-declare function clearTimeout(id?: number): void;
+declare function clearInterval(id: number | undefined): void;
+declare function clearTimeout(id: number | undefined): void;
 declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts
@@ -5250,8 +5250,8 @@ interface WindowOrWorkerGlobalScope {
  readonly performance: Performance;
  atob(data: string): string;
  btoa(data: string): string;
- clearInterval(id?: number): void;
- clearTimeout(id?: number): void;
+ clearInterval(id: number | undefined): void;
+ clearTimeout(id: number | undefined): void;
  createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
  fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5791,8 +5791,8 @@ declare var origin: string;
 declare var performance: Performance;
 declare function atob(data: string): string;
 declare function btoa(data: string): string;
-declare function clearInterval(id?: number): void;
-declare function clearTimeout(id?: number): void;
+declare function clearInterval(id: number | undefined): void;
+declare function clearTimeout(id: number | undefined): void;
 declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
 declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc
@@ -218,6 +218,38 @@
  }
  }
  }
+ },
+ "WindowOrWorkerGlobalScope": {
+ "methods": {
+ "method": {
+ "clearInterval": {
+ "signature": {
+ "0": {
+ "param": [
+ {
+ "name": "id",
+ "optional": false,
+ "additionalTypes": ["undefined"]
+ }
+ ]
+ }
+ }
+ },
+ "clearTimeout": {
+ "signature": {
+ "0": {
+ "param": [
+ {
+ "name": "id",
+ "optional": false,
+ "additionalTypes": ["undefined"]
+ }
+ ]
+ }
+ }
+ }
+ }
+ }
  }
  }
  },