Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Update Intune Windows Update resource logic #4910

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

Fixes the IntuneWindowsUpdateForBusinessFeatureUpdateProfileWindows10 resource so that create, update and test works with the requirements of the backend. Some errors might still be thrown during Set-TargetResource, and it is in the responsibility of the configuration owner to adhere to these requirements.

Please note: The RolloutSettings for this resource have the following constraints and notes:

  • When creating a policy:
    • If only a start date is specified, then the start date must be at least today.
      • If the desired state date is before the current date, it will be adjusted to the current date.
    • If a start and end date is specified, the start date must be the current date + 2 days, and
      the end date must be at least one day after the start date.
      • If the start date is before the current date + 2 days, it will be adjusted to this date.
  • When updating a policy:
    • If only a start date is specified, then the start date must either be the date from the current
      configuration or the current date (or later).
      • If the desired state date is before the current date, it will be adjusted to the current date.
    • If a start and end date is specified, the start date must be the current date + 2 days, and
      the end date must be at least one day after the start date.
      • If the start date is before the current date + 2 days, it will be adjusted to this date.
  • When testing a policy:
    • If the policy is missing and the start and end date are before the current date, it will return true.
    • If the start date is different but before the current start date and time, it will return true.

This Pull Request (PR) fixes the following issues

@ricmestre
Copy link
Contributor

This time I won't be able to test it so fast since I gotta make a new release of my product, I'll let you know later.

Thank you!

@FabienTschanz
Copy link
Contributor Author

No worries, I'm still testing it myself with some test values. That's why it's still in draft 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants