-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] NumPy 2.0 support #6454
Labels
Comments
jameslamb
changed the title
[python-package] Support NumPy 2.0
[python-package] NumPy 2.0 support
May 15, 2024
There will be at least one thing I know needs to change... |
This was referenced May 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
numpy
2.0 is coming out soon, and has release candidates up.We should test
lightgbm
against it, and if any changes are required, try to get them into the next release (#6439).Motivation
numpy
is a hard runtime dependency oflightgbm
. It would not be a good experience for users if incompatibility with its new major version leads to needing to manually pinnumpy<2
in their environments.Description
At a minimum, we should manually test
lightgbm
against thenumpy
release candidate. See dmlc/treelite#560 for a migration guide.It also would be great to set up CI that runs against nightlies of
numpy
,pandas
,scikit-learn
, andscipy
, maybe followingxarray
's example: https://github.com/pydata/xarray/blob/31111b3afe44fd6f7dac363264e94186cc5168d2/.github/workflows/upstream-dev-ci.yamlReferences
Links to other projects' upgrade and testing efforts: numpy/numpy#26191
The text was updated successfully, but these errors were encountered: