-
Notifications
You must be signed in to change notification settings - Fork 141
Conversation
cf03a49
to
6abc048
Compare
I suggest renaming |
710b920
to
868c82b
Compare
For some reason the images are not currently rendering properly and I can't figure out why: Going to open a separate issue for this and investigate later - this PR is already becoming oversized and it's not a major issue as it only affects two images, one of which is in the README anyway. Marking this PR as ready for review (many other issues to be opened shortly, RTD is far from finished!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good apart from one niggle - IDE settings should not be gitignored.
1c7b7d0
to
d35b503
Compare
42b6b0f
to
07ee50e
Compare
fc95144
to
686ca06
Compare
3cd63e9
to
11ecd1f
Compare
910060a
to
5353ae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image in https://innereye-deeplearning--768.org.readthedocs.build/md/deploy_on_aml.html is still not showing up. Is that expected?
not expected but I haven't figured out the fix yet, opening a new issue to focus on that next. It builds and displays just fine locally, and doesn't 404 when you navigate to the URL of the image. It just doesn't seem to be uploading the source images correctly for some reason. |
524d33e
to
efc5f9e
Compare
Closes #759
Moving all existing documentation onto RTD so that it is all in one consistent place. Also fixes problems with RTD not displaying all markdown documentation correctly.