This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
ENH: Upgrading package versions for security patches #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhessey
changed the title
peterhessey
force-pushed
the
phessey/critical-security-package-upgrades
branch
6 times, most recently
from
1d02425
to
e14ea6d
Compare
peterhessey
force-pushed
the
phessey/critical-security-package-upgrades
branch
from
e14ea6d
to
2e60a09
Compare
peterhessey
force-pushed
the
phessey/critical-security-package-upgrades
branch
2 times, most recently
from
949bc0c
to
54ce6b1
Compare
peterhessey
force-pushed
the
phessey/critical-security-package-upgrades
branch
from
54ce6b1
to
410a33e
Compare
ant0nsc
suggested changes
Sep 2, 2022
ant0nsc
approved these changes
Sep 13, 2022
kenza-bouzid
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading various packages to patch identified critical CVEs.
This involves updating pytorch-lightning to 1.6.4. This introduces a number of breaking changes for various components and tests which have been patched in this PR.
However, this includes two potentially problematic changes:
model_training.pynow no longer changes the current working directory before callingtrainer.fit(). This was as it was causing the CIFAR SSL container tests to fail as CIFAR is downloaded to/None/in the head of the dir. I'm personally of the opinion that we shouldn't be changing the working directory anyway as it's a perfect recipe for annoying problems like this one (took me a long time to figure out what was going on). I think it should be the responsibility of the user running non-InnerEye models to ensure that their files are being saved to the appropriate folder, not IE-DL's job to try and guess where they're going to go.expected_metricsintest_innereye_ssl_container_cifar10_resnet_simclr(). These regression tests were failing after updating the package versions so I updated the expected metrics to the new ones. The validation loss values had improved, the training ones worsened, neither significantly. This could affect other models but I'm not sure which models need to be checked!Also includes an upgrade to hi-ml v0.2.5, closing #801