Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

ENH: Add Environment Locking #735

Merged
merged 11 commits into from
Jun 1, 2022
Merged

ENH: Add Environment Locking #735

merged 11 commits into from
Jun 1, 2022

Conversation

peterhessey
Copy link
Contributor

Closes #726

This includes changes to how we handle primary and secondary dependencies in the InnerEye Deep Learning library. Locking is now performed through the use of conda export, preventing secondary versions from switching unexpectedly. Through the use of a bash script the env is locked and an environment.yml suitable for ingestion by AzureML is constructed.

This is far from a perfect solution, but at the very least significantly reduces the chance of pipelines failing due to secondary dependency version changes.

@peterhessey peterhessey marked this pull request as draft May 30, 2022 11:35
@peterhessey peterhessey marked this pull request as ready for review May 30, 2022 11:36
@peterhessey peterhessey marked this pull request as draft May 30, 2022 11:38
@fepegar fepegar requested a review from mebristo May 30, 2022 11:40
Copy link
Contributor

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two sections are still empty. Also, something wrong there with "environment_win.yml", it is marked as a binary file in the UI??

create_and_lock_environment.sh Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
@peterhessey peterhessey marked this pull request as ready for review May 30, 2022 15:26
@peterhessey peterhessey requested a review from ant0nsc May 30, 2022 15:27
Copy link
Contributor

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 2 minor things:

  • please add a "do not edit" comment in both locked environments
  • change the PR title to remove the "proof-of-concept" thing

environment_win.yml Show resolved Hide resolved
@peterhessey peterhessey changed the title ENH: Environment locking proof-of-concept ENH: Add Environment Locking May 30, 2022
create_and_lock_environment.sh Show resolved Hide resolved
create_and_lock_environment.sh Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
@peterhessey peterhessey requested a review from fepegar June 1, 2022 08:20
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments.

create_and_lock_environment.sh Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
docs/environment.md Outdated Show resolved Hide resolved
@peterhessey peterhessey enabled auto-merge (squash) June 1, 2022 09:22
@peterhessey peterhessey merged commit 92d9479 into main Jun 1, 2022
@peterhessey peterhessey deleted the conda-locking-POC branch June 1, 2022 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Environment "Locking" POC
3 participants