This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Update TorchIO version #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #672.
fepegar
force-pushed
the
672-update-torchio
branch
from
281bacb
to
ea6a570
Compare
javier-alvarez
previously approved these changes
Mar 2, 2022
|
Done. Is that better? |
|
This happens because InnerEye is asking TorchIO to place a patch in a location where a larger patch is meant to be, i.e., the input size to the aggregator is smaller than the sampled patch. This happens when the model output is smaller than the input. I have modified TorchIO so the error message when this happens is more informative. I will submit a PR here to pad the model outputs when this situation occurs. When the model outputs are expected to be smaller than the input, a large overlap is typically specified anyway, so the patches will be cropped inside the aggregator later on, so it doesn't matter much how they are padded initially. Hopefully, all that made some sense. |
ant0nsc
previously approved these changes
Mar 9, 2022
ant0nsc
approved these changes
Mar 11, 2022
javier-alvarez
approved these changes
Mar 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #672.
The new version of TorchIO fixes a small bug discovered recently which affects patch-based inference: