This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix in _convert_to_tensor_if_necessary so that also np.array get converted correctly #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vale-salvatelli
previously approved these changes
Jan 31, 2022
|
Looks good to me! thanks for taking care of this bug |
dccastro
previously approved these changes
Jan 31, 2022
Tests/SSL/test_ssl_containers.py
Outdated
| assert type(batch[SSLDataModuleType.ENCODER][1]) == torch.Tensor | ||
| assert type(batch[SSLDataModuleType.LINEAR_HEAD][0]) == torch.Tensor | ||
| assert type(batch[SSLDataModuleType.LINEAR_HEAD][1]) == torch.Tensor | ||
| assert type(batch[SSLDataModuleType.LINEAR_HEAD][2]) == torch.Tensor |
There was a problem hiding this comment.
Here it would be safer to use isinstance(...), in case we get a Tensor subclass, for example.
13396c1
javier-alvarez
approved these changes
Jan 31, 2022
vale-salvatelli
approved these changes
Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the _convert_to_tensor_if_necessary method so that PIL.Image as well as np.array get converted to torch.Tensor
The PR also includes a test.