This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
Enable building an ensemble model from the cross validation checkpoints of a BYO Lightning model #529
Closed
Closed
Enable building an ensemble model from the cross validation checkpoints of a BYO Lightning model #529
Changes from 1 commit
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
1250de0
Use registered model for inference
Shruthi42 efc34fb
Merge branch 'main' into shbannur/load_registered_models
Shruthi42 f94b2e9
Bug fix
Shruthi42 7430785
Fix tests
Shruthi42 229b7ea
Fix tests
Shruthi42 16a09c3
mypy
Shruthi42 ee957d8
Fix tests
Shruthi42 596efee
Add tests
Shruthi42 2c2160f
Fix tests
Shruthi42 fe6fa93
Fix tests
Shruthi42 45895e7
Add test
Shruthi42 41f1b48
Fix tests
Shruthi42 f6bb7a2
Fix test
Shruthi42 3e3b069
Remove unnecessary function
Shruthi42 c0de1e6
Update tests
Shruthi42 0889a88
Flake8
Shruthi42 f98b22e
Fix tests
Shruthi42 d73f769
mypy
Shruthi42 f4dfbe7
Merge branch 'main' into shbannur/load_registered_models
Shruthi42 2767e18
Loosening multiple checkpoint check in run_inference_for_lightning_mo…
8a63e0a
WiP very scrappy!
116e566
WiP more mess
7107e27
WiP: bones of test class
d0c7724
Refactoring run_inference_for_lightning_models
6735d2c
mypy fixes
585511b
Merge branch 'main' into timregan/527-ensembles-for-BYOL-xval
4df8c09
WiP annotations and test
05a67dc
WiP: saving mid task for lunch
dumbledad 8d93907
Correcting GPU -> CPU typo in comment
dumbledad e7ba7f1
Method can be static
dumbledad e4ebfcb
WiP fiddling
dumbledad 7625a48
Example ensemble from InnerEyeInference
dumbledad f5b288c
flake8 and mypy fixes
dumbledad a79673f
mypy fixes
dumbledad 3e9ec7e
tidying unused parameters
559a717
WiP simple temp test for train/test ensemble
f7be221
Renaming InnerEyeInference methods
a3179a8
tidy up
f7bdc7f
Matching new naming
939ec5a
renaming params
f206057
naming
d71f498
Unit test WiP
6987f99
don't be strict with state_dict
dumbledad f6e025f
first unit test takes shape
dumbledad 500bf11
Unit test works, but doesn't check much
dumbledad 0d97fe9
renaming unit test
b204f08
Merge branch 'main' into shbannur/load_registered_models
Shruthi42 dd17d78
Change docstring
Shruthi42 388e0a8
Update CHANGELOG.md
Shruthi42 d727fe1
Rename
Shruthi42 fa7a6e4
Fix test
Shruthi42 581c6a9
WiP ensemble unit test with value check
1134c0f
Merge branch 'main' into timregan/527-ensembles-for-BYOL-xval
e35db5b
Address PR comments
Shruthi42 9093b7e
Use list of pytest markers
Shruthi42 bf072c0
Move model_id to WorkflowParams
Shruthi42 5a76cc1
missed some name changes
2d75d24
WiP swapping back to checkpoints not accruing child runs
e064483
Refactor extra_downloaded_run_id
Shruthi42 168eb29
unit test working
838bb48
Update documentation and argparser
Shruthi42 0f3690c
flake & mypy
9c7f6b4
Revert changes to generic_parsing
Shruthi42 d612c6e
Update documentation
Shruthi42 6861178
Flake8 and mypy
Shruthi42 98c7683
Shruthi's changes to run_ml
54c845e
Merge branch 'shbannur/load_registered_models' into timregan/527-ense…
48aca37
WiP abstracting ensemble inference
d3d8477
WiP
dumbledad a4ea25a
Ensemble inference base
dumbledad 5e7f0b1
Merge branch 'main' into timregan/527-ensembles-for-BYOL-xval
dumbledad a71fa90
Ended up with changes to 2 files I did not touch!
dumbledad 0874a74
Restoring (and fixing) run_ml changes
dumbledad 88bb96d
mypy
dumbledad 424b2e7
WiP
dumbledad 4903b96
run_ml unit test v1
547ed7d
WiP pre pruning ensemble stuff
538a7a4
refactored to avoid recursion blow-up
002886c
Merge branch 'main' into timregan/527-ensembles-for-BYOL-xval
dumbledad c6ca034
additional comments and remove inheritance
dumbledad 484fe4a
removing duplicated unit test
dumbledad b771137
more comments
dumbledad 6d57d08
test tidy
dumbledad 6a9fd75
flake fixes
dumbledad cea51e4
WiP
dumbledad 9fc696a
on_ensemble_inference_start needn't call down
dumbledad b947452
Old WiP changes
dumbledad f7d22f4
Adding HelloEnsembleInference
dumbledad af079ae
run_ml changes with parameter
dumbledad 38b12b7
Wi{ on mypy and tidy pre unit test fix
dumbledad c255774
mypy fixes
dumbledad 2db1857
import fix so test discovery works
dumbledad 21044e6
Fixing test discovery
dumbledad 4f10169
WiP fixing unit test
dumbledad e0e31e6
Unit test works
dumbledad 1d23735
file system test
dumbledad 1486bff
Adding register and actually building ensemble
ff8fef1
Removed call to innnereye_config
ddb3c9f
unit test fix
dumbledad e71d49b
fix for the reference error on AzureML
dumbledad db18fdd
Merge branch 'main' into timregan/527-ensembles-for-BYOL-xval
dumbledad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
run_ml changes with parameter
- Loading branch information
commit af079ae909aa92e73c3949e7d9d9915a0a2df29c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this?