This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Check bool parameter is either true or false (after lower) #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JonathanTripp
commented
Jun 7, 2021
•
- Add test that a boolean command line parameter is one of: 'on', 't', 'true', 'y', 'yes', '1' (for true) or 'off', 'f', 'false', 'n', 'no', '0' (for false) after lower()
- If a flag default is False, then allow --flag to set it to True (so the ==True is unnecessary)
- If a flag default is True, then allow --no-flag to set it to False (so the ==False is unnecessary)
ant0nsc
reviewed
Jun 8, 2021
ant0nsc
previously approved these changes
Jun 8, 2021
ant0nsc
suggested changes
Jun 9, 2021
ant0nsc
approved these changes
Jun 10, 2021
Shruthi42
approved these changes
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.