Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix cross validation for classification models and update pytorch-lightning #432

Merged
merged 86 commits into from
Apr 16, 2021

Conversation

melanibe
Copy link
Contributor

@melanibe melanibe commented Apr 12, 2021

  • Various fixes to metrics aggregation/download/paths for classification cross-validation runs:
    ** Fixed metrics aggregation for multi-gpu
    ** Fixed path for test metrics
    ** Added split recording for test set inference during CV
    ** Removed Ensemble from the folds taken into account for aggregated results in classification CV
    ** Removed Val inference for Ensemble (as val of parent fold is in training set of ensemble)
    ** Make CrossValidation folder follow a simple Train/ Val/ Test/ structure
  • Add end-2-end test for classification model in PR build
  • Updating pytorch-lightning to 1.2.7
  • Fixed ddp setting when multi-node but only 1 gpu per node
  • WARNING: removing test for training multi-node as new PL version breaks multi-node training.
    Closes No end-to-end AML job for classification model #433

@melanibe melanibe changed the title Fix cross validation for classification models (metrics path) Fix cross validation for classification models and update environment Apr 12, 2021
@melanibe melanibe marked this pull request as ready for review April 12, 2021 20:21
@melanibe melanibe requested a review from ant0nsc April 12, 2021 20:21
@melanibe melanibe requested a review from Shruthi42 April 12, 2021 20:28
environment.yml Outdated Show resolved Hide resolved
@melanibe melanibe requested a review from ant0nsc April 15, 2021 16:03
Copy link
Member

@dccastro dccastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Just proposed very superficial changes.

@melanibe melanibe requested a review from dccastro April 15, 2021 17:44
dccastro
dccastro previously approved these changes Apr 15, 2021
Copy link
Member

@dccastro dccastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, all clear 👍

@melanibe melanibe enabled auto-merge (squash) April 15, 2021 18:12
ant0nsc
ant0nsc previously approved these changes Apr 16, 2021
@ant0nsc ant0nsc dismissed stale reviews from dccastro and themself via f9182ad April 16, 2021 09:29
@melanibe melanibe merged commit 28404f0 into main Apr 16, 2021
@melanibe melanibe deleted the melanibe/fix-cv-classification branch April 16, 2021 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No end-to-end AML job for classification model
3 participants