This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
Fix cross validation for classification models and update pytorch-lightning #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dccastro
reviewed
Apr 15, 2021
dccastro
reviewed
Apr 15, 2021
dccastro
reviewed
Apr 15, 2021
dccastro
reviewed
Apr 15, 2021
dccastro
reviewed
Apr 15, 2021
dccastro
reviewed
Apr 15, 2021
dccastro
reviewed
Apr 15, 2021
dccastro
reviewed
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Just proposed very superficial changes.
dccastro
previously approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, all clear 👍
ant0nsc
previously approved these changes
Apr 16, 2021
ant0nsc
approved these changes
Apr 16, 2021
dccastro
approved these changes
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Fixed metrics aggregation for multi-gpu
** Fixed path for test metrics
** Added split recording for test set inference during CV
** Removed Ensemble from the folds taken into account for aggregated results in classification CV
** Removed Val inference for Ensemble (as val of parent fold is in training set of ensemble)
** Make CrossValidation folder follow a simple Train/ Val/ Test/ structure
Closes No end-to-end AML job for classification model #433