This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Speed up dicom loading by factor 30x #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ant0nsc
previously approved these changes
Mar 31, 2021
dccastro
previously approved these changes
Mar 31, 2021
ant0nsc
approved these changes
Apr 7, 2021
dccastro
approved these changes
Apr 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move dicom loading function from SimpleITK to pydicom. Time improvement per dicom: 1.5 sec -> 0.05 sec.
Note: The load_dicom function now returns a 2D array if the input array was 2D (before array of shape [1, x, y] for 2D image). Conversion to 3D if necessary (e.g. to stack frames) is taken care of in the subsequent functions.