This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Added possibility to set name of dataset csv as part of model configu… #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ant0nsc
previously approved these changes
Mar 10, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closes #403 |
ant0nsc
previously approved these changes
Mar 10, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ant0nsc
reviewed
Mar 10, 2021
…to DeepLearningConfig class
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Shruthi42
suggested changes
Mar 12, 2021
|
@Shruthi42, thanks for spotting this! |
Shruthi42
suggested changes
Mar 15, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Shruthi42
approved these changes
Mar 15, 2021
JonathanTripp
approved these changes
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to address Issue #403.
Definition of the dataset csv file name has been enabled by allowing the parameter dataset_csv to be set as part of model configuration. The parameter is initialised to DATASET_CSV_FILE_NAME in InnerEye/ML/config.py, then is used to locate the dataset csv file in InnerEye/ML/config.py, in InnerEye/ML/run_ml.py and in InnerEye/ML/utils/ml_util.py. An associated unit test has been added to Tests/ML/test_config_helpers.py.