Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Support Multilabel classification models with png files #391

Merged
merged 90 commits into from
Mar 19, 2021

Conversation

javier-alvarez
Copy link
Contributor

@javier-alvarez javier-alvarez commented Feb 8, 2021

  • This PR adds support for multilabel classification models. Multiclass models (where labels are mutually exclusive) are not supported. Changes made:
    • dataset.csv can include multiple labels per sample
    • Loss functions changed to support multilabel classification tasks
    • Extra report for multilabel classification tasks
  • Add support for png images

@javier-alvarez javier-alvarez changed the title Add png Support Multilabel classification models with png files Feb 10, 2021
@javier-alvarez javier-alvarez marked this pull request as ready for review February 11, 2021 13:58
Copy link
Contributor

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is no documentation in the MD files about how to use a multi-class model. Similarly, there should be a description for multi-label case.
  • The metrics that we are presently computing make sense (I think) for multi-label, but not for multi-class with mutually exclusive labels.

InnerEye/ML/dataset/scalar_dataset.py Show resolved Hide resolved
InnerEye/ML/dataset/scalar_dataset.py Outdated Show resolved Hide resolved
InnerEye/ML/dataset/scalar_dataset.py Outdated Show resolved Hide resolved
InnerEye/ML/dataset/scalar_dataset.py Outdated Show resolved Hide resolved
InnerEye/ML/dataset/scalar_dataset.py Outdated Show resolved Hide resolved
Tests/ML/reports/test_classification_report.py Outdated Show resolved Hide resolved
InnerEye/ML/reports/classification_report.ipynb Outdated Show resolved Hide resolved
InnerEye/ML/reports/classification_report.ipynb Outdated Show resolved Hide resolved
InnerEye/ML/reports/classification_report.py Outdated Show resolved Hide resolved
Tests/ML/models/test_scalar_model.py Show resolved Hide resolved
InnerEye/ML/utils/supervised_criterion.py Outdated Show resolved Hide resolved
InnerEye/ML/scalar_config.py Outdated Show resolved Hide resolved
InnerEye/ML/scalar_config.py Outdated Show resolved Hide resolved
melanibe
melanibe previously approved these changes Mar 18, 2021
ant0nsc
ant0nsc previously approved these changes Mar 18, 2021
@Shruthi42 Shruthi42 dismissed stale reviews from ant0nsc and melanibe via 51b4a6d March 19, 2021 09:52
ant0nsc
ant0nsc previously approved these changes Mar 19, 2021
@Shruthi42 Shruthi42 enabled auto-merge (squash) March 19, 2021 10:55
melanibe
melanibe previously approved these changes Mar 19, 2021
@Shruthi42 Shruthi42 dismissed stale reviews from melanibe and ant0nsc via 5b040e7 March 19, 2021 13:18
ant0nsc
ant0nsc previously approved these changes Mar 19, 2021
ant0nsc
ant0nsc previously approved these changes Mar 19, 2021
@Shruthi42 Shruthi42 merged commit 917f8d0 into main Mar 19, 2021
@Shruthi42 Shruthi42 deleted the jaalvare/multiclass_classification branch March 19, 2021 16:03
@ant0nsc ant0nsc linked an issue Mar 19, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds fail non-reproducibly with papermill timeout errors
4 participants