Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Ignore local dataset argument when running inside AML runs #238

Merged
merged 9 commits into from
Sep 22, 2020
Merged

Ignore local dataset argument when running inside AML runs #238

merged 9 commits into from
Sep 22, 2020

Conversation

melanibe
Copy link
Contributor

@melanibe melanibe commented Sep 22, 2020 •
edited
Loading

This PR modifies mount_or_download_dataset such that we ignore the local_dataset argument inside AML runs (only used for local runs).

ant0nsc
ant0nsc previously approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid breaking that functionality in the future, can you add test coverage? For example, in build-pr.yaml, you could add a switch that sets a local_dataset on the PR model.

InnerEye/ML/run_ml.py Outdated Show resolved Hide resolved
ant0nsc
ant0nsc previously approved these changes Sep 22, 2020
View reviewed changes
@melanibe melanibe merged commit a112b39 into master Sep 22, 2020
@melanibe melanibe deleted the melanibe/ignore-local-dataset-aml branch September 22, 2020 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@javier-alvarez javier-alvarez javier-alvarez approved these changes

@ant0nsc ant0nsc ant0nsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@melanibe @javier-alvarez @ant0nsc