This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 141
Make updates to avoid lightning deprecation warnings #751
Labels
Comments
dkarhi
added a commit
to dkarhi/InnerEye-DeepLearning
that referenced
this issue
May 19, 2023
I'm fixing a few issues that would prevent upgrading the pytorch-lightning package. Trainer.lr_schedulers is being replaced with trainer.lr_scheduler_configs. In future versions, using trainer.logger with multiple loggers will only return the first logger available, so I'm iterating through trainer.loggers instead. And LightningLoggerBase.close is being replaced with LightningLoggerBase.finalize. Closes microsoft#751
I took a look at this in the current main branch (commit 2877002). The first two warning have already been fixed, but the third is still present. There are also 2 new warnings:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
🚀 Feature
Update packages and/or InnerEye code, so as not to have lightning deprecation warnings.
Motivation
When running the InnerEye code (commit b42043f), the following deprecation warnings are issued:
Pitch
It would be nice if packages and/or code could be updated so as to avoid the deprecation warnings - and to be future ready :)
Alternatives
There's probably a way of switching off the warnings, but addressing them would be better than hiding them.
Additional context
The deprecation warnings can be obtained by running the
HelloWorld
model, as outlined in README.md:AB#6281
The text was updated successfully, but these errors were encountered: